Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/forgot password pages #168

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Chore/forgot password pages #168

wants to merge 8 commits into from

Conversation

r4zendev
Copy link

@r4zendev r4zendev commented Jan 8, 2024

What does this PR do?

This PR migrates the /auth/forgot-password pages to use the app directory (which runs under the App Router).
Migrated page exist under /future/auth/forgot-password and is accessible at all times.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)

How should this be tested?

Pages performance can be accessed via their individual URLs and various metrics could be validated to be improved compared to the previous implementation.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Chore/forgot password pages". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@r4zendev r4zendev force-pushed the chore/forgot-password-pages branch 3 times, most recently from 8292007 to 1b29763 Compare January 15, 2024 15:28
@r4zendev r4zendev force-pushed the chore/forgot-password-pages branch 2 times, most recently from 302bacf to a5c871e Compare January 18, 2024 16:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
❗️ .env changes Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r4zendev @DmytroHryshyn @hbjORbj @zomars